ssdong commented on a change in pull request #2784:
URL: https://github.com/apache/hudi/pull/2784#discussion_r615508860
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestTable.java
##########
@@ -177,10 +161,14 @@ public HoodieTestTable addDeltaCommit(String instantTime)
throws Exception {
return this;
}
- public HoodieTestTable addReplaceCommit(String instantTime,
HoodieRequestedReplaceMetadata requestedReplaceMetadata,
HoodieReplaceCommitMetadata metadata) throws Exception {
+ public HoodieTestTable addReplaceCommit(
+ String instantTime,
+ HoodieRequestedReplaceMetadata requestedReplaceMetadata,
+ HoodieReplaceCommitMetadata completeReplaceMetadata,
+ HoodieCommitMetadata inflightReplaceMetadata) throws Exception {
Review comment:
hmm, if you track it down to `createInflightReplaceCommit` where
`HoodieCommitMetadata` is being referenced, a `null` check is being presented
there. However, I do agree an `Optional` reminds people of a null check though
the
`o.isPresent()` check is _hardly_ any better than `o != null`. I could make
the change and also update `createRequestedReplaceCommit` to adopt the same
Optional `HoodieRequestedReplaceMetadata`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
