umehrot2 commented on a change in pull request #2283: URL: https://github.com/apache/hudi/pull/2283#discussion_r616288457
########## File path: hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java ########## @@ -164,7 +165,13 @@ private void syncHoodieTable(String tableName, boolean useRealtimeInputFormat) { LOG.info("Storage partitions scan complete. Found " + writtenPartitionsSince.size()); // Sync the partitions if needed syncPartitions(tableName, writtenPartitionsSince); - + // Sync the table properties if need + if (cfg.tableProperties != null) { + Map<String, String> tableProperties = ConfigUtils.toMap(cfg.tableProperties); + hoodieHiveClient.updateTableProperties(tableName, tableProperties); + LOG.info("Sync table properties for " + tableName + ", table properties is: " + + cfg.tableProperties); + } Review comment: @pengzhiwei2018 I understand that. In the `syncSchema()` there is a check for schema difference. Perhaps we should move this inside that to avoid this being run every time. And for the first time when table is created, we can do it as part of create table. Thoughts ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org