[GitHub] [hudi] RocMarshal commented on a change in pull request #2822: [Hotfix][hudi-sync] Refactor method up to parent-class

[GitBox]

RocMarshal commented on a change in pull request #2822:
URL: https://github.com/apache/hudi/pull/2822#discussion_r619809749



##########
File path: 
hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/TestHiveSyncTool.java
##########
@@ -635,4 +635,20 @@ public void testConnectExceptionIgnoreConfigSet() throws 
IOException, URISyntaxE
         "Table " + HiveTestUtil.hiveSyncConfig.tableName + " should not exist 
initially");
   }
 
+  @ParameterizedTest
+  @MethodSource("useJdbc")
+  public void testTypeConverter(boolean useJdbc) throws Exception {
+    HiveTestUtil.hiveSyncConfig.useJdbc = useJdbc;
+    HiveTestUtil.createCOWTable("100", 5, true);
+    HoodieHiveClient hiveClient =
+        new HoodieHiveClient(HiveTestUtil.hiveSyncConfig, 
HiveTestUtil.getHiveConf(), HiveTestUtil.fileSystem);
+    String sql = String.format("CREATE TABLE IF NOT EXISTS `%s.%s` 
(`decimal_col` DECIMAL(9,8))",

Review comment:
       Other types of columns?
   @leesf 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org