RocMarshal commented on a change in pull request #2822:
URL: https://github.com/apache/hudi/pull/2822#discussion_r620411008
##########
File path:
hudi-sync/hudi-sync-common/src/main/java/org/apache/hudi/sync/common/AbstractSyncHoodieClient.java
##########
@@ -29,20 +29,25 @@
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.Path;
+import org.apache.hudi.common.util.ValidationUtils;
import org.apache.log4j.LogManager;
import org.apache.log4j.Logger;
import org.apache.parquet.schema.MessageType;
+import java.io.Serializable;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;
import java.util.List;
import java.util.Map;
+import java.util.Objects;
public abstract class AbstractSyncHoodieClient {
private static final Logger LOG =
LogManager.getLogger(AbstractSyncHoodieClient.class);
+ public static final TypeConverter DECIMAL_TYPE_CONVERTOR = new
TypeConverter() {};
Review comment:
IMO, The current default implementation is the default implementation of
the decimal type convertor. And we would do a special implementation by
extending `TypeConverter` in the specific scene. So, keeping
`DECIMAL_TYPE_CONVERTOR` would be a fine choice in the case...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
