mpouttu commented on a change in pull request #2907:
URL: https://github.com/apache/hudi/pull/2907#discussion_r630431625
##########
File path:
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -566,27 +566,15 @@ private[hudi] object HoodieSparkSqlWriter {
log.info(s"Compaction Scheduled is $compactionInstant")
- val metaSyncSuccess = metaSync(spark, parameters,
tableInstantInfo.basePath, schema)
+ val metaSyncSuccess = metaSync(spark, parameters,
tableInstantInfo.basePath, schema)
log.info(s"Is Async Compaction Enabled ? $asyncCompactionEnabled")
if (!asyncCompactionEnabled) {
client.close()
}
(commitSuccess && metaSyncSuccess, compactionInstant)
} else {
- log.error(s"${tableInstantInfo.operation} failed with $errorCount errors
:")
Review comment:
Actually the take(100) is ok in the trace logging of the original code,
it will still skip the total count as it could cause memory issues as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
