nsivabalan commented on a change in pull request #2925:
URL: https://github.com/apache/hudi/pull/2925#discussion_r645977253
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/config/DefaultHoodieConfig.java
##########
@@ -26,6 +26,11 @@
*/
public class DefaultHoodieConfig implements Serializable {
+ public static final String QUERY_TYPE_OPT_KEY =
"hoodie.datasource.query.type";
Review comment:
yeah, I don't see any usages for this config outside of HiveSyncTool.
So, better to keep it local. And Initially I thought on similar lines as
@umehrot2 that we can leverage table name to detect. but later realized that,
this particular config is used while syncing schema and the caller hard codes
the type(there is only one caller to this method and is local to
HoodieSyncTool). So, may not be required to leverage table name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
