[GitHub] [hudi] leesf commented on a change in pull request #3105: [HUDI-2038] Rollback pending compaction when schedule new compaction

[GitBox]

leesf commented on a change in pull request #3105:
URL: https://github.com/apache/hudi/pull/3105#discussion_r655305310



##########
File path: 
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/compact/FlinkScheduleCompactionActionExecutor.java
##########
@@ -72,6 +75,17 @@ protected HoodieCompactionPlan scheduleCompaction() {
     boolean compactable = 
needCompact(config.getInlineCompactTriggerStrategy());
     if (compactable) {
       LOG.info("Generating compaction plan for merge on read table " + 
config.getBasePath());
+      // roll back the inflight compaction first
+      HoodieTimeline pendingCompactionTimeline = 
table.getActiveTimeline().filterPendingCompactionTimeline();

Review comment:
       @yuzhaojing So would we know the reason why compaction fails? and if we 
just rollback the inflight compaction and schedule a new one, the new one will 
possibly fail again?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org