nsivabalan commented on a change in pull request #3108:
URL: https://github.com/apache/hudi/pull/3108#discussion_r656526739
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/model/OverwriteWithLatestAvroPayload.java
##########
@@ -94,6 +94,6 @@ protected boolean isDeleteRecord(GenericRecord genericRecord)
{
* Return true if value equals defaultValue otherwise false.
*/
public Boolean overwriteField(Object value, Object defaultValue) {
- return defaultValue == null ? value == null :
defaultValue.toString().equals(String.valueOf(value));
Review comment:
Thanks for the fix. Can you please write a test case for few diff data
types. In general, its a good practice to always accompany bugs with tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
