[ https://issues.apache.org/jira/browse/HUDI-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17373838#comment-17373838 ]
ASF GitHub Bot commented on HUDI-1468: -------------------------------------- codecov-commenter edited a comment on pull request #3211: URL: https://github.com/apache/hudi/pull/3211#issuecomment-872810385 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3211?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3211](https://codecov.io/gh/apache/hudi/pull/3211?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (56f4484) into [master](https://codecov.io/gh/apache/hudi/commit/6eca06d074520140d7bc67b48bd2b9a5b76f0a87?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6eca06d) will **increase** coverage by `18.25%`. > The diff coverage is `60.30%`. [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3211/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #3211 +/- ## ============================================= + Coverage 47.51% 65.76% +18.25% + Complexity 5429 796 -4633 ============================================= Files 922 101 -821 Lines 40968 3529 -37439 Branches 4105 351 -3754 ============================================= - Hits 19464 2321 -17143 + Misses 19780 1070 -18710 + Partials 1724 138 -1586 ``` | Flag | Coverage Δ | | |---|---|---| | hudicli | `?` | | | hudiclient | `65.76% <60.30%> (+31.18%)` | :arrow_up: | | hudicommon | `?` | | | hudiflink | `?` | | | hudihadoopmr | `?` | | | hudisparkdatasource | `?` | | | hudisync | `?` | | | huditimelineservice | `?` | | | hudiutilities | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...trategy/SparkRecentDaysClusteringPlanStrategy.java](https://codecov.io/gh/apache/hudi/pull/3211/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L2NsdXN0ZXJpbmcvcGxhbi9zdHJhdGVneS9TcGFya1JlY2VudERheXNDbHVzdGVyaW5nUGxhblN0cmF0ZWd5LmphdmE=) | `100.00% <ø> (+24.39%)` | :arrow_up: | | [...SparkSelectedPartitionsClusteringPlanStrategy.java](https://codecov.io/gh/apache/hudi/pull/3211/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L2NsdXN0ZXJpbmcvcGxhbi9zdHJhdGVneS9TcGFya1NlbGVjdGVkUGFydGl0aW9uc0NsdXN0ZXJpbmdQbGFuU3RyYXRlZ3kuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [.../run/strategy/SingleSparkJobExecutionStrategy.java](https://codecov.io/gh/apache/hudi/pull/3211/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L2NsdXN0ZXJpbmcvcnVuL3N0cmF0ZWd5L1NpbmdsZVNwYXJrSm9iRXhlY3V0aW9uU3RyYXRlZ3kuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...ring/update/strategy/SparkAllowUpdateStrategy.java](https://codecov.io/gh/apache/hudi/pull/3211/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L2NsdXN0ZXJpbmcvdXBkYXRlL3N0cmF0ZWd5L1NwYXJrQWxsb3dVcGRhdGVTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (ø)` | | | [...SparkInsertOverwriteTableCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3211/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9TcGFya0luc2VydE92ZXJ3cml0ZVRhYmxlQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | `0.00% <ø> (ø)` | | | [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://codecov.io/gh/apache/hudi/pull/3211/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `72.19% <50.00%> (+0.13%)` | :arrow_up: | | [...strategy/SparkSizeBasedClusteringPlanStrategy.java](https://codecov.io/gh/apache/hudi/pull/3211/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L2NsdXN0ZXJpbmcvcGxhbi9zdHJhdGVneS9TcGFya1NpemVCYXNlZENsdXN0ZXJpbmdQbGFuU3RyYXRlZ3kuamF2YQ==) | `70.27% <70.27%> (ø)` | | | [...un/strategy/MultipleSparkJobExecutionStrategy.java](https://codecov.io/gh/apache/hudi/pull/3211/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L2NsdXN0ZXJpbmcvcnVuL3N0cmF0ZWd5L011bHRpcGxlU3BhcmtKb2JFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `92.00% <92.00%> (ø)` | | | [...er/SparkExecuteClusteringCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3211/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NsdXN0ZXIvU3BhcmtFeGVjdXRlQ2x1c3RlcmluZ0NvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `82.85% <92.30%> (-6.57%)` | :arrow_down: | | [...un/strategy/SparkSortAndSizeExecutionStrategy.java](https://codecov.io/gh/apache/hudi/pull/3211/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L2NsdXN0ZXJpbmcvcnVuL3N0cmF0ZWd5L1NwYXJrU29ydEFuZFNpemVFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `100.00% <100.00%> (ø)` | | | ... and [825 more](https://codecov.io/gh/apache/hudi/pull/3211/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3211?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3211?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6eca06d...56f4484](https://codecov.io/gh/apache/hudi/pull/3211?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > incremental read support with clustering > ---------------------------------------- > > Key: HUDI-1468 > URL: https://issues.apache.org/jira/browse/HUDI-1468 > Project: Apache Hudi > Issue Type: Sub-task > Components: Incremental Pull > Affects Versions: 0.9.0 > Reporter: satish > Assignee: liwei > Priority: Blocker > Labels: pull-request-available > Fix For: 0.9.0 > > > As part of clustering, metadata such as hoodie_commit_time changes for > records that are clustered. This is specific to > SparkBulkInsertBasedRunClusteringStrategy implementation. Figure out a way to > carry commit_time from original record to support incremental queries. > Also, incremental queries dont work with 'replacecommit' used by clustering > HUDI-1264. Change incremental query to work for replacecommits created by > Clustering. -- This message was sent by Atlassian Jira (v8.3.4#803005)