[ 
https://issues.apache.org/jira/browse/HUDI-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375041#comment-17375041
 ] 

ASF GitHub Bot commented on HUDI-1996:
--------------------------------------

jhsb25 commented on a change in pull request #3097:
URL: https://github.com/apache/hudi/pull/3097#discussion_r664150601



##########
File path: packaging/hudi-integ-test-bundle/pom.xml
##########
@@ -615,25 +615,25 @@
     <dependency>
       <groupId>io.confluent</groupId>
       <artifactId>kafka-avro-serializer</artifactId>
-      <version>3.0.0</version>
+      <version>5.3.4</version>
     </dependency>
 
     <dependency>
       <groupId>io.confluent</groupId>
       <artifactId>common-config</artifactId>
-      <version>3.0.0</version>
+      <version>5.3.4</version>

Review comment:
       done

##########
File path: 
hudi-utilities/src/test/java/org/apache/hudi/utilities/schema/SchemaRegistryProviderTest.java
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.utilities.schema;
+
+import com.fasterxml.jackson.databind.JsonNode;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.apache.avro.Schema;
+import org.apache.hudi.common.config.TypedProperties;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mockito;
+
+import java.io.ByteArrayInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.HttpURLConnection;
+import java.nio.charset.StandardCharsets;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+
+class SchemaRegistryProviderTest {

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> When using SchemaRegistryProvider.java cant pass basic auth creds in url
> ------------------------------------------------------------------------
>
>                 Key: HUDI-1996
>                 URL: https://issues.apache.org/jira/browse/HUDI-1996
>             Project: Apache Hudi
>          Issue Type: Bug
>          Components: DeltaStreamer
>            Reporter: Randal Boyle
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.10.0
>
>
> **Background**
> When trying to use the 
> [SchemaRegistryProvider.java|https://github.com/apache/hudi/blob/c21209cb58a5cff3267aca9f17fe7d2c4edd3190/hudi-utilities/src/main/java/org/apache/hudi/utilities/schema/SchemaRegistryProvider.java#L54-L59]
>  with basic auths we cannot pass creds in the url due to this issue 
> [https://bugs.openjdk.java.net/browse/JDK-5043482.] This means when using 
> basic auth with confluent cloud schema registry there is no way to 
> authenticate.
>  
> **Story**
> As a user of hudi delta streamer who uses the confuent schema registry with 
> basic auth
> I would like to be able to pass basic authentication credentials to the 
> SchemaRegistryProvider
> So that i can authenticate with the confluent schema registry and obtain my 
> desired schemas
> **Acceptance Criteria**
> I can pass basic auth creds to the SchemaRegistryProvider and the schema can 
> be obtained from the registry.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to