[ 
https://issues.apache.org/jira/browse/HUDI-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375150#comment-17375150
 ] 

ASF GitHub Bot commented on HUDI-2135:
--------------------------------------

garyli1019 commented on a change in pull request #3226:
URL: https://github.com/apache/hudi/pull/3226#discussion_r664203627



##########
File path: 
hudi-flink/src/main/java/org/apache/hudi/sink/compact/FlinkCompactionConfig.java
##########
@@ -89,6 +89,9 @@
   @Parameter(names = {"--compaction-tasks"}, description = "Parallelism of 
tasks that do actual compaction, default is -1", required = false)
   public Integer compactionTasks = -1;
 
+  @Parameter(names = {"--schedule", "-sc"}, description = "Schedule 
compaction", required = false)

Review comment:
       Should we add some comments that async scheduling is not recommended and 
the possible risk? Most users won't dig this deep




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add compaction schedule option for flink
> ----------------------------------------
>
>                 Key: HUDI-2135
>                 URL: https://issues.apache.org/jira/browse/HUDI-2135
>             Project: Apache Hudi
>          Issue Type: Improvement
>          Components: Flink Integration
>            Reporter: Danny Chen
>            Assignee: Danny Chen
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.9.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to