nsivabalan commented on a change in pull request #3149: URL: https://github.com/apache/hudi/pull/3149#discussion_r664607907
########## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/BulkInsertInternalPartitionerWithRowsFactory.java ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.execution.bulkinsert; + +import org.apache.hudi.exception.HoodieException; +import org.apache.hudi.table.BulkInsertPartitioner; + +import org.apache.spark.sql.Dataset; +import org.apache.spark.sql.Row; + +/** + * A factory to generate built-in partitioner to repartition input Rows into at least + * expected number of output spark partitions for bulk insert operation. + */ +public abstract class BulkInsertInternalPartitionerWithRowsFactory { + + public static BulkInsertPartitioner<Dataset<Row>> get(BulkInsertSortMode sortMode) { + switch (sortMode) { + case NONE: + return new NonSortPartitionerWithRows(); + case GLOBAL_SORT: + return new GlobalSortPartitionerWithRows(); + case PARTITION_SORT: + return new RDDPartitionSortPartitionerWithRows(); Review comment: again, for the same reason. in regular write client path, this partitioner is called as RDDPartitionSortPartitioner. Wanted to be consistent. Or would prefer to change both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
