[ 
https://issues.apache.org/jira/browse/HUDI-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377448#comment-17377448
 ] 

ASF GitHub Bot commented on HUDI-1828:
--------------------------------------

leesf commented on a change in pull request #3237:
URL: https://github.com/apache/hudi/pull/3237#discussion_r666277226



##########
File path: 
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/HoodieReadClient.java
##########
@@ -144,7 +145,15 @@ private void assertSqlContext() {
 
     // record locations might be same for multiple keys, so need a unique list
     Set<String> uniquePaths = new HashSet<>(paths);
-    Dataset<Row> originalDF = 
sqlContextOpt.get().read().parquet(uniquePaths.toArray(new 
String[uniquePaths.size()]));
+    Dataset<Row> originalDF = null;
+    if (uniquePaths.size() == 0) {

Review comment:
       merge with 
`paths.get(0).endsWith(HoodieFileFormat.PARQUET.getFileExtension()`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Ensure All Tests Pass with ORC format
> -------------------------------------
>
>                 Key: HUDI-1828
>                 URL: https://issues.apache.org/jira/browse/HUDI-1828
>             Project: Apache Hudi
>          Issue Type: Sub-task
>          Components: Storage Management
>            Reporter: Teresa Kang
>            Priority: Major
>              Labels: pull-request-available
>
> Run all tests with HoodieTableConfig.DEFAULT_BASE_FILE_FORMAT=ORC, ensure all 
> tests pass.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to