leesf commented on a change in pull request #3250: URL: https://github.com/apache/hudi/pull/3250#discussion_r668001831
########## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java ########## @@ -339,7 +339,7 @@ .withDocumentation(""); public static final ConfigProperty<String> EXTERNAL_RECORD_AND_SCHEMA_TRANSFORMATION = ConfigProperty - .key(AVRO_SCHEMA + ".externalTransformation") + .key(AVRO_SCHEMA.key() + ".externalTransformation") Review comment: when using spark option("hoodie.avro.schema.externalTransformation", true) to pass the config, the `externalTransformation` will be changed to lowercase `externaltransformation` , can we fix it? ########## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java ########## @@ -339,7 +339,7 @@ .withDocumentation(""); public static final ConfigProperty<String> EXTERNAL_RECORD_AND_SCHEMA_TRANSFORMATION = ConfigProperty - .key(AVRO_SCHEMA + ".externalTransformation") + .key(AVRO_SCHEMA.key() + ".externalTransformation") Review comment: I prefer `hoodie.avro.schema.external.transformation` to align with other configs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org