[ 
https://issues.apache.org/jira/browse/HUDI-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380489#comment-17380489
 ] 

ASF GitHub Bot commented on HUDI-1860:
--------------------------------------

Samrat002 commented on a change in pull request #3184:
URL: https://github.com/apache/hudi/pull/3184#discussion_r669487932



##########
File path: 
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/SparkInsertOverwriteCommitActionExecutor.java
##########
@@ -66,11 +65,6 @@ protected Partitioner getPartitioner(WorkloadProfile 
profile) {
     return new SparkInsertOverwritePartitioner(profile, context, table, 
config);
   }
 
-  @Override
-  protected String getCommitActionType() {

Review comment:
       
   @vinothchandar,
   I wasn't able to get it properly, If you explain a bit more elaborately! i 
can make change accordingly 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add INSERT_OVERWRITE support to DeltaStreamer
> ---------------------------------------------
>
>                 Key: HUDI-1860
>                 URL: https://issues.apache.org/jira/browse/HUDI-1860
>             Project: Apache Hudi
>          Issue Type: Sub-task
>            Reporter: Sagar Sumit
>            Assignee: Samrat Deb
>            Priority: Major
>              Labels: pull-request-available
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> As discussed in [this 
> RFC|https://cwiki.apache.org/confluence/display/HUDI/RFC+-+14+%3A+JDBC+incremental+puller],
>  having full fetch mode use the inser_overwrite to write to sync would be 
> better as it can handle schema changes. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to