danny0405 commented on a change in pull request #3267:
URL: https://github.com/apache/hudi/pull/3267#discussion_r670069995



##########
File path: 
hudi-common/src/test/java/org/apache/hudi/common/model/TestOverwriteWithLatestAvroPayload.java
##########
@@ -72,6 +72,17 @@ public void testActiveRecords() throws IOException {
 
     assertEquals(payload1.combineAndGetUpdateValue(record2, schema).get(), 
record1);
     assertEquals(payload2.combineAndGetUpdateValue(record1, schema).get(), 
record2);
+
+    GenericRecord record3 = new GenericData.Record(schema);
+    record3.put("id", "3");
+    record3.put("partition", "partition2");

Review comment:
       `ts` is actually not the `preCombine` field, the `preCombine` was passed 
explicitly.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to