[ https://issues.apache.org/jira/browse/HUDI-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17381663#comment-17381663 ]
ASF GitHub Bot commented on HUDI-2181: -------------------------------------- danny0405 commented on a change in pull request #3281: URL: https://github.com/apache/hudi/pull/3281#discussion_r670920668 ########## File path: hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/FlinkCreateHandle.java ########## @@ -42,8 +42,8 @@ * * <p>For the first mini-batch, it initializes and sets up the next file path to write, * then closes the file writer. The subsequent mini-batches are appended to a file with new name, - * the new file would then rename to this file name, Review comment: The subsequent mini-batches are appended to a file => The subsequent mini-batches are written to a file The docs is actually correct, see `FlinkMergeAndReplaceHandle`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Refine for FlinkCreateHandle > ---------------------------- > > Key: HUDI-2181 > URL: https://issues.apache.org/jira/browse/HUDI-2181 > Project: Apache Hudi > Issue Type: Improvement > Components: Flink Integration > Reporter: zhangminglei > Assignee: zhangminglei > Priority: Major > Labels: pull-request-available > > FlinkCreateHandle does not append to the original file for subsequent > mini-batches, instead every inserts batch would create a new file. -- This message was sent by Atlassian Jira (v8.3.4#803005)