[
https://issues.apache.org/jira/browse/HUDI-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382414#comment-17382414
]
ASF GitHub Bot commented on HUDI-1860:
--------------------------------------
Samrat002 commented on a change in pull request #3184:
URL: https://github.com/apache/hudi/pull/3184#discussion_r671598590
##########
File path:
hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieDeltaStreamer.java
##########
@@ -1695,6 +1695,54 @@ public void
testJdbcSourceIncrementalFetchInContinuousMode() {
}
}
+ @Test
+ public void testInsertOverwrite() throws Exception {
+ String tableBasePath = dfsBasePath + "/insert_overwrite";
+ // Initial insert
+ HoodieDeltaStreamer.Config cfg = TestHelpers.makeConfig(tableBasePath,
WriteOperationType.INSERT);
+ new HoodieDeltaStreamer(cfg, jsc).sync();
+ TestHelpers.assertRecordCount(1000, tableBasePath + "/*/*.parquet",
sqlContext);
+ TestHelpers.assertDistanceCount(1000, tableBasePath + "/*/*.parquet",
sqlContext);
+ TestHelpers.assertCommitMetadata("00000", tableBasePath, dfs, 1);
+ // No new data => no commits.
+ cfg.sourceLimit = 0;
+ new HoodieDeltaStreamer(cfg, jsc).sync();
+ TestHelpers.assertRecordCount(1000, tableBasePath + "/*/*.parquet",
sqlContext);
+ TestHelpers.assertDistanceCount(1000, tableBasePath + "/*/*.parquet",
sqlContext);
+ TestHelpers.assertCommitMetadata("00000", tableBasePath, dfs, 1);
+ // insert overwrite
+ cfg.sourceLimit = 1000;
+ cfg.operation = WriteOperationType.INSERT_OVERWRITE;
Review comment:
hi @nsivabalan ,
for the 2nd point
do we need to cover the test case here, because I see test
(https://github.com/apache/hudi/blob/master/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/TestHoodieClientOnCopyOnWriteStorage.java#L1227)
This test case is to check Deltastreamer when `op` is `INSERT_OVERWRITE`.
Moreover using the same `SparkRDDWriteClient`. I feel it would be redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add INSERT_OVERWRITE support to DeltaStreamer
> ---------------------------------------------
>
> Key: HUDI-1860
> URL: https://issues.apache.org/jira/browse/HUDI-1860
> Project: Apache Hudi
> Issue Type: Sub-task
> Reporter: Sagar Sumit
> Assignee: Samrat Deb
> Priority: Major
> Labels: pull-request-available
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> As discussed in [this
> RFC|https://cwiki.apache.org/confluence/display/HUDI/RFC+-+14+%3A+JDBC+incremental+puller],
> having full fetch mode use the inser_overwrite to write to sync would be
> better as it can handle schema changes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
