[ 
https://issues.apache.org/jira/browse/HUDI-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382446#comment-17382446
 ] 

ASF GitHub Bot commented on HUDI-1447:
--------------------------------------

nsivabalan commented on a change in pull request #2438:
URL: https://github.com/apache/hudi/pull/2438#discussion_r671607330



##########
File path: 
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java
##########
@@ -212,6 +234,9 @@ public KafkaOffsetGen(TypedProperties props) {
       Set<TopicPartition> topicPartitions = partitionInfoList.stream()
               .map(x -> new TopicPartition(x.topic(), 
x.partition())).collect(Collectors.toSet());
 
+      if (Config.KAFKA_CHECKPOINT_TYPE_TIMESTAMP.equals(kafkaCheckpointType) 
&& isValidCheckpointType(lastCheckpointStr)) {
+        lastCheckpointStr = getOffsetsByTimestamp(consumer, partitionInfoList, 
topicPartitions, topicName, Long.parseLong(lastCheckpointStr.get()));
+      }

Review comment:
       ok, I get it now. makes sense. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> DeltaStreamer kafka source supports consuming from specified timestamp
> ----------------------------------------------------------------------
>
>                 Key: HUDI-1447
>                 URL: https://issues.apache.org/jira/browse/HUDI-1447
>             Project: Apache Hudi
>          Issue Type: New Feature
>          Components: DeltaStreamer
>            Reporter: wangxianghu#1
>            Assignee: liujinhui
>            Priority: Major
>              Labels: pull-request-available, sev:high, user-support-issues
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to