[
https://issues.apache.org/jira/browse/HUDI-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384786#comment-17384786
]
ASF GitHub Bot commented on HUDI-2203:
--------------------------------------
danny0405 commented on a change in pull request #3317:
URL: https://github.com/apache/hudi/pull/3317#discussion_r673824944
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/model/OverwriteWithLatestAvroPayload.java
##########
@@ -49,7 +49,7 @@ public OverwriteWithLatestAvroPayload(Option<GenericRecord>
record) {
@Override
public OverwriteWithLatestAvroPayload
preCombine(OverwriteWithLatestAvroPayload another) {
// pick the payload with greatest ordering value
- if (another.orderingVal.compareTo(orderingVal) > 0) {
+ if (another.orderingVal.compareTo(orderingVal) >= 0) {
return another;
Review comment:
The original logic is actually right, because the passed in `another` is
the old existing value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> When the orderingVal is the same, take the latest one
> -----------------------------------------------------
>
> Key: HUDI-2203
> URL: https://issues.apache.org/jira/browse/HUDI-2203
> Project: Apache Hudi
> Issue Type: Improvement
> Reporter: liujinhui
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> OverwriteWithLatestAvroPayload.
> When the orderingVal is the same, select the later data
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
