[
https://issues.apache.org/jira/browse/HUDI-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387153#comment-17387153
]
ASF GitHub Bot commented on HUDI-2209:
--------------------------------------
danny0405 commented on a change in pull request #3334:
URL: https://github.com/apache/hudi/pull/3334#discussion_r676382204
##########
File path:
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/model/HoodieRowData.java
##########
@@ -0,0 +1,184 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.client.model;
+
+import org.apache.hudi.common.model.HoodieRecord;
+
+import org.apache.flink.table.data.ArrayData;
+import org.apache.flink.table.data.DecimalData;
+import org.apache.flink.table.data.MapData;
+import org.apache.flink.table.data.RawValueData;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.data.StringData;
+import org.apache.flink.table.data.TimestampData;
+import org.apache.flink.types.RowKind;
+
+/**
+ * Internal Row implementation for Hoodie Row. It wraps an {@link RowData} and
keeps meta columns locally. But the {@link RowData}
+ * does include the meta columns as well just that {@link HoodieRowData} will
intercept queries for meta columns and serve from its
+ * copy rather than fetching from {@link RowData}.
+ */
+public class HoodieRowData implements RowData {
+
+ private final String commitTime;
+ private final String commitSeqNumber;
+ private final String recordKey;
+ private final String partitionPath;
+ private final String fileName;
+ private final RowData row;
+ private final int metaColumnsNum;
+
+ public HoodieRowData(String commitTime,
+ String commitSeqNumber,
+ String recordKey,
+ String partitionPath,
+ String fileName,
+ RowData row) {
+ this.commitTime = commitTime;
+ this.commitSeqNumber = commitSeqNumber;
+ this.recordKey = recordKey;
+ this.partitionPath = partitionPath;
+ this.fileName = fileName;
+ this.row = row;
+ this.metaColumnsNum = HoodieRecord.HOODIE_META_COLUMNS.size();
+ }
+
+ @Override
+ public int getArity() {
+ return 5 + row.getArity();
+ }
+
+ @Override
+ public RowKind getRowKind() {
+ return row.getRowKind();
+ }
+
+ @Override
+ public void setRowKind(RowKind kind) {
+ this.row.setRowKind(kind);
+ }
+
+ private String getMetaColumnVal(int ordinal) {
+ switch (ordinal) {
+ case 0: {
+ return commitTime;
+ }
+ case 1: {
+ return commitSeqNumber;
+ }
+ case 2: {
+ return recordKey;
+ }
+ case 3: {
+ return partitionPath;
+ }
+ case 4: {
+ return fileName;
+ }
+ default:
+ throw new IllegalArgumentException("Not expected");
+ }
+ }
+
+ @Override
+ public boolean isNullAt(int ordinal) {
+ if (ordinal < metaColumnsNum) {
+ return null == getMetaColumnVal(ordinal);
+ }
+ return row.isNullAt(ordinal - metaColumnsNum);
+ }
+
+ @Override
+ public boolean getBoolean(int ordinal) {
+ return row.getBoolean(ordinal - metaColumnsNum);
Review comment:
No, we can use a `JoinedRowData` instead but that code is actually not
that efficient as this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Bulk insert for flink writer
> ----------------------------
>
> Key: HUDI-2209
> URL: https://issues.apache.org/jira/browse/HUDI-2209
> Project: Apache Hudi
> Issue Type: New Feature
> Components: Flink Integration
> Reporter: Danny Chen
> Assignee: Danny Chen
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
