leesf commented on a change in pull request #3330:
URL: https://github.com/apache/hudi/pull/3330#discussion_r679936652



##########
File path: 
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/SparkRDDWriteClient.java
##########
@@ -460,6 +487,17 @@ protected void preCommit(String instantTime, 
HoodieCommitMetadata metadata) {
         Option.of(metadata), config, 
txnManager.getLastCompletedTransactionOwner());
   }
 
+  @Override
+  protected void saveStatisticsInfo(List<String> touchFiles, String cols, 
String indexPath, String saveMode) {
+    if (touchFiles.isEmpty() || cols.isEmpty() || indexPath.isEmpty()) {
+      LOG.warn("save nothing to index table");

Review comment:
       save statistics into .hoodie/.index/xxx ?

##########
File path: 
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/SparkRDDWriteClient.java
##########
@@ -460,6 +487,17 @@ protected void preCommit(String instantTime, 
HoodieCommitMetadata metadata) {
         Option.of(metadata), config, 
txnManager.getLastCompletedTransactionOwner());
   }
 
+  @Override
+  protected void saveStatisticsInfo(List<String> touchFiles, String cols, 
String indexPath, String saveMode) {
+    if (touchFiles.isEmpty() || cols.isEmpty() || indexPath.isEmpty()) {
+      LOG.warn("save nothing to index table");

Review comment:
       save statistics into .hoodie/index/xxx ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to