[ 
https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391291#comment-17391291
 ] 

ASF GitHub Bot commented on HUDI-2177:
--------------------------------------

nsivabalan commented on a change in pull request #3315:
URL: https://github.com/apache/hudi/pull/3315#discussion_r680643364



##########
File path: 
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java
##########
@@ -157,6 +157,11 @@
       .withDocumentation("When enabled, populates all meta fields. When 
disabled, no meta fields are populated "
           + "and incremental queries will not be functional. This is only 
meant to be used for append only/immutable data for batch processing");
 
+  public static final ConfigProperty<String> HOODIE_TABLE_KEY_GENERATOR_CLASS 
= ConfigProperty
+      .key("hoodie.datasource.write.keygenerator.class")

Review comment:
       my intention here is to just use the same config someone uses with spark 
datasource. Rather than introducing new configs. But guess we don't follow that 
for partition path nor record keys. Will fix it. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Virtual keys support for Compaction
> -----------------------------------
>
>                 Key: HUDI-2177
>                 URL: https://issues.apache.org/jira/browse/HUDI-2177
>             Project: Apache Hudi
>          Issue Type: Sub-task
>          Components: Writer Core
>            Reporter: sivabalan narayanan
>            Assignee: sivabalan narayanan
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.9.0
>
>
> Virtual keys support for Compaction



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to