danny0405 commented on a change in pull request #3384:
URL: https://github.com/apache/hudi/pull/3384#discussion_r681450750



##########
File path: 
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java
##########
@@ -357,7 +357,6 @@ public void write(GenericRecord oldRecord) {
         }
       }
 
-      keyToNewRecords.clear();
       ((ExternalSpillableMap) keyToNewRecords).close();

Review comment:
       The `close` method already release the `inMemoryMap` so that we can 
remove the invocation of `clear`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to