tsianglei commented on a change in pull request #3402:
URL: https://github.com/apache/hudi/pull/3402#discussion_r682461965



##########
File path: hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java
##########
@@ -152,6 +153,7 @@ public static HoodieWriteConfig 
getHoodieClientConfig(Configuration conf) {
                     // actually Flink cleaning is always with parallelism 1 now
                     .withCleanerParallelism(20)
                     
.archiveCommitsWith(conf.getInteger(FlinkOptions.ARCHIVE_MIN_COMMITS), 
conf.getInteger(FlinkOptions.ARCHIVE_MAX_COMMITS))
+                    
.withCleanerPolicy(HoodieCleaningPolicy.KEEP_LATEST_COMMITS)
                     .build())

Review comment:
       build() method get policy use 
compactionConfig.getString(CLEANER_POLICY_PROP),this method doesn't return 
default value, but null. if not set then will return null. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to