vinothchandar commented on a change in pull request #3285:
URL: https://github.com/apache/hudi/pull/3285#discussion_r684468443
##########
File path:
hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java
##########
@@ -76,6 +76,17 @@ private FlinkOptions() {
.withDescription("The default partition name in case the dynamic
partition"
+ " column value is null/empty string");
+ public static final ConfigOption<Boolean> CHANGELOG_ENABLED = ConfigOptions
+ .key("changelog.enabled")
Review comment:
Love it. Change log :)
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/util/SpillableMapUtils.java
##########
@@ -107,21 +109,42 @@ public static long generateChecksum(byte[] data) {
return valueSizeEstimator.sizeEstimate(value);
}
+ /**
+ * Returns the string value of the given record {@code rec} and field {@code
fieldName}.
+ * The field and value both could be missing.
+ *
+ * @param rec The record
+ * @param fieldName The field name
+ *
+ * @return the string form of the field
+ * or empty if the schema does not contain the field name or the value is
null
+ */
+ private static Option<String> getNullableValAsString(GenericRecord rec,
String fieldName) {
Review comment:
Should this be in AvroUtils?
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -373,6 +373,12 @@
.withDocumentation("Whether to allow generation of empty commits, even
if no data was written in the commit. "
+ "It's useful in cases where extra metadata needs to be published
regardless e.g tracking source offsets when ingesting data");
+ public static final ConfigProperty<Boolean> ALLOW_OPERATION_METADATA_FIELD =
ConfigProperty
+ .key("hoodie.allow.operation.metadata.field")
+ .defaultValue(false)
Review comment:
let's add sinceVersion() ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
