[
https://issues.apache.org/jira/browse/HUDI-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17396429#comment-17396429
]
ASF GitHub Bot commented on HUDI-1129:
--------------------------------------
nsivabalan commented on a change in pull request #2927:
URL: https://github.com/apache/hudi/pull/2927#discussion_r685690476
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/TableSchemaResolver.java
##########
@@ -375,6 +377,37 @@ public static boolean isSchemaCompatible(String oldSchema,
String newSchema) {
return isSchemaCompatible(new Schema.Parser().parse(oldSchema), new
Schema.Parser().parse(newSchema));
}
+ /**
+ * Get latest schema either from incoming schema or table schema.
+ * @param writeSchema incoming batch's write schema.
+ * @param convertTableSchemaToAddNamespace {@code true} if table schema
needs to be converted. {@code false} otherwise.
+ * @param converterFn converter function to be called over table schema (to
add namespace may be). Each caller can decide if any conversion is required.
+ * @return the latest schema.
+ */
+ public Schema getLatestSchema(Schema writeSchema, boolean
convertTableSchemaToAddNamespace,
Review comment:
Did not name this as latestTableSchema, bcoz, incoming schema could be
the latest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> AvroConversionUtils unable to handle avro to row transformation when passing
> evolved schema
> --------------------------------------------------------------------------------------------
>
> Key: HUDI-1129
> URL: https://issues.apache.org/jira/browse/HUDI-1129
> Project: Apache Hudi
> Issue Type: Bug
> Components: DeltaStreamer
> Reporter: Balaji Varadarajan
> Assignee: Sagar Sumit
> Priority: Blocker
> Labels: pull-request-available, sev:critical, user-support-issues
> Fix For: 0.9.0
>
>
> Unit test to repro :
> [https://github.com/apache/hudi/pull/1844/files#diff-2c3763c5782af9c3cbc02e2935211587R476]
> Context in :
> [https://github.com/apache/hudi/issues/1845#issuecomment-665180775] (issue 2)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
