vinothchandar commented on a change in pull request #3413:
URL: https://github.com/apache/hudi/pull/3413#discussion_r686275274
##########
File path:
hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieDeltaStreamer.java
##########
@@ -1435,6 +1476,26 @@ public void
testParquetDFSSourceWithSchemaFilesAndTransformer() throws Exception
testParquetDFSSource(true,
Collections.singletonList(TripsWithDistanceTransformer.class.getName()));
}
+ @Test
+ public void testORCDFSSourceWithoutSchemaProviderAndNoTransformer() throws
Exception {
+ testORCDFSSource(false, null);
+ }
+
+ @Test
+ public void testORCDFSSourceWithoutSchemaProviderAndTransformer() throws
Exception {
+ testORCDFSSource(false,
Collections.singletonList(TripsWithDistanceTransformer.class.getName()));
+ }
+
+ @Test
+ public void testORCDFSSourceWithSourceSchemaFileAndNoTransformer() throws
Exception {
Review comment:
for sake of test runtime. could we test just 1-2 combos here. most of
the testing done for row source (ParquetDFS) should cover already?
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/util/AvroOrcUtils.java
##########
@@ -796,4 +800,32 @@ private static Schema getActualSchemaType(Schema
unionSchema) {
return Schema.createUnion(nonNullMembers);
}
}
+
+ public static void addAvroRecord(
Review comment:
can this sit somewhere in a test utils class? given its only used by a
test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
