[
https://issues.apache.org/jira/browse/HUDI-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405089#comment-17405089
]
ASF GitHub Bot commented on HUDI-2229:
--------------------------------------
danny0405 commented on a change in pull request #3495:
URL: https://github.com/apache/hudi/pull/3495#discussion_r696444008
##########
File path:
hudi-flink/src/main/java/org/apache/hudi/streamer/HoodieFlinkStreamer.java
##########
@@ -21,30 +21,18 @@
import org.apache.hudi.common.model.HoodieRecord;
import org.apache.hudi.common.util.Option;
import org.apache.hudi.configuration.FlinkOptions;
-import org.apache.hudi.sink.CleanFunction;
-import org.apache.hudi.sink.StreamWriteOperatorFactory;
-import org.apache.hudi.sink.bootstrap.BootstrapOperator;
-import org.apache.hudi.sink.compact.CompactFunction;
-import org.apache.hudi.sink.compact.CompactionCommitEvent;
-import org.apache.hudi.sink.compact.CompactionCommitSink;
-import org.apache.hudi.sink.compact.CompactionPlanEvent;
-import org.apache.hudi.sink.compact.CompactionPlanOperator;
-import org.apache.hudi.sink.partitioner.BucketAssignFunction;
-import org.apache.hudi.sink.partitioner.BucketAssignOperator;
-import org.apache.hudi.sink.transform.RowDataToHoodieFunctions;
Review comment:
Also the config options of the `HoodieFlinkStreamer` is out of sync with
`FlinkOptions`, we can promote that in another PR i guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Refact hoodie stream creator in flink
> -------------------------------------
>
> Key: HUDI-2229
> URL: https://issues.apache.org/jira/browse/HUDI-2229
> Project: Apache Hudi
> Issue Type: Improvement
> Components: Flink Integration
> Reporter: wu xingbo
> Priority: Trivial
> Labels: beginner, pull-request-available
> Fix For: 0.10.0
>
> Original Estimate: 12h
> Remaining Estimate: 12h
>
> the procedure of hoodiedatastreamsink is duplicated in current
> HoodieFlinkStreamer and HoodieTableSink, such as index bootstrap,
> compaction,etc.
> propose to refact them as same function in utility
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
