zhangyue19921010 commented on a change in pull request #3536:
URL: https://github.com/apache/hudi/pull/3536#discussion_r697141153
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/table/view/TestHoodieTableFileSystemView.java
##########
@@ -141,6 +141,45 @@ public void
testViewForFileSlicesWithNoBaseFileNonPartitioned() throws Exception
testViewForFileSlicesWithNoBaseFile(1, 0, "");
}
+ @Test
+ public void testCloseHoodieTableFileSystemView() throws Exception {
+ String instantTime1 = "1";
+ String instantTime2 = "2";
+ String clusteringInstantTime3 = "3";
+ String clusteringInstantTime4 = "4";
+
+ // prepare metadata
+ HoodieActiveTimeline commitTimeline = metaClient.getActiveTimeline();
+ Map<String, List<String>> partitionToReplaceFileIds = new HashMap<>();
+ List<String> replacedFileIds = new ArrayList<>();
+ replacedFileIds.add("fake_file_id");
+ partitionToReplaceFileIds.put("fake_partition_path", replacedFileIds);
+
+ // prepare Instants
+ HoodieInstant instant1 = new HoodieInstant(true,
HoodieTimeline.COMMIT_ACTION, instantTime1);
+ HoodieInstant instant2 = new HoodieInstant(true,
HoodieTimeline.COMMIT_ACTION, instantTime2);
+ HoodieInstant clusteringInstant3 = new HoodieInstant(true,
HoodieTimeline.REPLACE_COMMIT_ACTION, clusteringInstantTime3);
+ HoodieInstant clusteringInstant4 = new HoodieInstant(true,
HoodieTimeline.REPLACE_COMMIT_ACTION, clusteringInstantTime4);
+ HoodieCommitMetadata commitMetadata =
+ CommitUtils.buildMetadata(Collections.emptyList(),
partitionToReplaceFileIds, Option.empty(), WriteOperationType.CLUSTER, "",
HoodieTimeline.REPLACE_COMMIT_ACTION);
+
+ saveAsComplete(commitTimeline, instant1, Option.empty());
+ saveAsComplete(commitTimeline, instant2, Option.empty());
+ saveAsComplete(commitTimeline, clusteringInstant3, Option.empty());
+ saveAsComplete(commitTimeline, clusteringInstant4,
Option.of(commitMetadata.toJsonString().getBytes(StandardCharsets.UTF_8)));
+
+ refreshFsView();
+
+ // Now create a scenario where archiving deleted replace commits
(requested,inflight and replacecommit)
+ boolean deleteReplaceCommit = new File(this.basePath + "/.hoodie/" +
clusteringInstantTime3 + ".replacecommit").delete();
+ boolean deleteReplaceCommitRequested = new File(this.basePath +
"/.hoodie/" + clusteringInstantTime3 + ".replacecommit.requested").delete();
+ boolean deleteReplaceCommitInflight = new File(this.basePath + "/.hoodie/"
+ clusteringInstantTime3 + ".replacecommit.inflight").delete();
+
+ // confirm deleted
+ assertTrue(deleteReplaceCommit && deleteReplaceCommitInflight &&
deleteReplaceCommitRequested);
+ fsView.close();
Review comment:
Okay, changed. Thanks for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
