[
https://issues.apache.org/jira/browse/HUDI-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17410000#comment-17410000
]
ASF GitHub Bot commented on HUDI-648:
-------------------------------------
pratyakshsharma commented on a change in pull request #3312:
URL: https://github.com/apache/hudi/pull/3312#discussion_r702303108
##########
File path:
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala
##########
@@ -724,6 +725,21 @@ object DataSourceWriteOptions {
val KAFKA_AVRO_VALUE_DESERIALIZER = KAFKA_AVRO_VALUE_DESERIALIZER_CLASS.key()
@Deprecated
val SCHEMA_PROVIDER_CLASS_PROP = "hoodie.deltastreamer.schemaprovider.class"
+
+ val ERROR_TABLE_ENABLE_OPT_KEY: ConfigProperty[String] = ConfigProperty
+ .key("hoodie.write.error.table.enabled")
+ .defaultValue("false")
+ .withDocumentation("Enable the internal Error Table which saves error
record");
+
+ val HOODIE_WRITE_STATUS_CLASS_OPT_KEY: ConfigProperty[String] =
ConfigProperty
+ .key("hoodie.writestatus.class")
+ .defaultValue(classOf[WriteStatus].getName)
+ .withDocumentation("");
+
+ val WRITESTATUS_FAILURE_FRACTION_OPT_KEY: ConfigProperty[String] =
ConfigProperty
+ .key("hoodie.memory.writestatus.failure.fraction")
+ .defaultValue("")
+ .withDocumentation("");
Review comment:
Can we add documentation here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Implement error log/table for Datasource/DeltaStreamer/WriteClient/Compaction
> writes
> ------------------------------------------------------------------------------------
>
> Key: HUDI-648
> URL: https://issues.apache.org/jira/browse/HUDI-648
> Project: Apache Hudi
> Issue Type: New Feature
> Components: DeltaStreamer, Spark Integration, Writer Core
> Reporter: Vinoth Chandar
> Assignee: liujinhui
> Priority: Major
> Labels: pull-request-available, sev:normal, user-support-issues
> Attachments: image-2021-03-03-11-40-21-083.png
>
>
> We would like a way to hand the erroring records from writing or compaction
> back to the users, in a separate table or log. This needs to work generically
> across all the different writer paths.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
