[
https://issues.apache.org/jira/browse/HUDI-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411542#comment-17411542
]
ASF GitHub Bot commented on HUDI-485:
-------------------------------------
hudi-bot commented on pull request #2768:
URL: https://github.com/apache/hudi/pull/2768#issuecomment-914648175
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5d32a15900a2160467db1f742f4b44ecd8b15daa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5d32a15900a2160467db1f742f4b44ecd8b15daa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5d32a15900a2160467db1f742f4b44ecd8b15daa UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Check for where clause is wrong in HiveIncrementalPuller
> --------------------------------------------------------
>
> Key: HUDI-485
> URL: https://issues.apache.org/jira/browse/HUDI-485
> Project: Apache Hudi
> Issue Type: Sub-task
> Components: Incremental Pull, newbie
> Reporter: Pratyaksh Sharma
> Assignee: Pratyaksh Sharma
> Priority: Major
> Labels: pull-request-available, sev:high
>
> HiveIncrementalPuller checks the clause in incrementalSqlFile like this ->
> if (!incrementalSQL.contains("`_hoodie_commit_time` > '%targetBasePath'"))
> { LOG.info("Incremental SQL : " + incrementalSQL + " does not contain
> `_hoodie_commit_time` > %targetBasePath. Please add " + "this clause for
> incremental to work properly."); throw new HoodieIncrementalPullSQLException(
> "Incremental SQL does not have clause `_hoodie_commit_time` >
> '%targetBasePath', which " + "means its not pulling incrementally"); }
> Basically we are trying to add a placeholder here which is later replaced
> with config.fromCommitTime here -
> incrementalPullSQLtemplate.add("incrementalSQL",
> String.format(incrementalSQL, config.fromCommitTime));
> Hence, the above check needs to replaced with `_hoodie_commit_time` > %s
--
This message was sent by Atlassian Jira
(v8.3.4#803005)