yanghua commented on pull request #3674: URL: https://github.com/apache/hudi/pull/3674#issuecomment-927459881
@xushiyan Thanks for sharing your thoughts. Let's discuss some points. > i see the point here is to allow PR reviewer easily identify dep changes. Yes, that's one of the purposes. Another one is to let the contributors or developers/users have a way to know and view the dependencies of those bundles if that way(meet conflict problems). So I output them into the codebase. Just like the Kyuubi has [done.](https://github.com/apache/incubator-kyuubi/pull/1162/files) > it turns out to have quite some logic and not friendly to maintainers who are not familiar with bash IMO, It's a tool just like other tools in the codebase. We do not need to spend much time to change or maintain it. And we can add more comments and a better usage guide. It's the first version in order to receive other inputs from you guys. > why dependency:build-classpath not dependency:tree? Because it's easier and more readable. `build-classpath` looks like `ls` behavior and flatted to a dependencies list. While `tree` contains nested `| \ + -` right? It's harder to deal with. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
