nsivabalan commented on a change in pull request #3740:
URL: https://github.com/apache/hudi/pull/3740#discussion_r719807050
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/storage/HoodieConcatHandle.java
##########
@@ -94,4 +107,34 @@ public void write(GenericRecord oldRecord) {
}
recordsWritten++;
}
+
+ boolean needsUpdateLocation() {
+ return true;
+ }
+
+ @Override
+ public List<WriteStatus> close() {
+ try {
+ while (recordItr.hasNext()) {
+ HoodieRecord<T> record = recordItr.next();
Review comment:
can we try to re-use code across merge handle and this. lines 119 to
133. If incase we need to make some fix in merge handle, we might miss to fix
it here.
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/storage/HoodieConcatHandle.java
##########
@@ -94,4 +107,34 @@ public void write(GenericRecord oldRecord) {
}
recordsWritten++;
}
+
+ boolean needsUpdateLocation() {
Review comment:
do we need this? already in merge handle this is set to true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
