nsivabalan edited a comment on pull request #3590:
URL: https://github.com/apache/hudi/pull/3590#issuecomment-933938711


   > @nsivabalan have we unit tested `HoodieBackedTableMetadata` or 
`BaseTableMetadata` here?
   
   I started writing unit tests and later realized that all of our existing 
validation is happening using apis in BaseTableMetadata (getAllPartitionPaths 
and getAllFilesInPartition). Also there are tests to test reader wrt valid 
instants separately. So, I just enhanced existing tests and added extra 
validation that fileSystemMetadata is not used during these validations(or in 
other words only metadata table is used strictly during these validations). 
   In summary, I ensured we have tests covering HoodieBackedTableMetadata and 
HoodieBackedTableMetadataWriter for all of its methods.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to