yihua commented on a change in pull request #3741: URL: https://github.com/apache/hudi/pull/3741#discussion_r726799705
########## File path: hudi-common/src/main/java/org/apache/hudi/common/data/HoodieData.java ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.common.data; + +import org.apache.hudi.common.function.SerializableFunction; + +import java.io.Serializable; +import java.util.Iterator; +import java.util.List; +import java.util.Properties; + +/** + * An abstraction for a data collection of objects in type T to store the reference + * and do transformation. + * + * @param <T> type of object. + */ +public abstract class HoodieData<T> implements Serializable { + /** + * @return the collection of objects. + */ + public abstract Object get(); + + + /** + * @return whether the collection is empty. + */ + public abstract boolean isEmpty(); + + /** + * Caches the data. + * + * @param properties config in properties. + */ + public abstract void persist(Properties properties); Review comment: I put it here to abstract the common logic in compaction so that caching-related logic does not have to be in engine-specific helpers, to simplify the logic. For Flink, this is just No-OP in the `HoodieListData` implementation. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
