SteNicholas commented on a change in pull request #3779: URL: https://github.com/apache/hudi/pull/3779#discussion_r727107543
########## File path: hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/HoodieFlinkWriteClient.java ########## @@ -412,8 +421,21 @@ private void writeTableMetadata(HoodieTable<T, List<HoodieRecord<T>>, List<Hoodi @Override protected HoodieTable<T, List<HoodieRecord<T>>, List<HoodieKey>, List<WriteStatus>> getTableAndInitCtx(WriteOperationType operationType, String instantTime) { HoodieTableMetaClient metaClient = createMetaClient(true); - new UpgradeDowngrade(metaClient, config, context, FlinkUpgradeDowngradeHelper.getInstance()) - .run(HoodieTableVersion.current(), instantTime); + UpgradeDowngrade upgradeDowngrade = new UpgradeDowngrade(metaClient, config, context, FlinkUpgradeDowngradeHelper.getInstance()); Review comment: @leesf , `HoodieJavaWriteClient` has no `BaseUpgradeDowngradeHelper` implementation, therefore it could be duplicated here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org