codope commented on a change in pull request #3799:
URL: https://github.com/apache/hudi/pull/3799#discussion_r728979206
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/BootstrapExecutor.java
##########
@@ -159,10 +159,14 @@ public void execute() throws IOException {
* Sync to Hive.
*/
private void syncHive() {
- if (cfg.enableHiveSync) {
+ if (cfg.enableHiveSync || cfg.enableHiveSync) {
Review comment:
Redundant condition. Did you mean to add some other condition?
##########
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java
##########
@@ -49,6 +49,9 @@
@Parameter(names = {"--jdbc-url"}, description = "Hive jdbc connect url")
public String jdbcUrl;
+ @Parameter(names = {"--metastore-uris"}, description = "Hive metastore uris")
+ public String metastoreUris;
Review comment:
This should be used somewhere right. I mean in HoodieHiveClient or
HiveSyncTool. I don't see it is being used anywhere in `hudi-hive-sync` module.
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
##########
@@ -618,9 +618,10 @@ private void syncMeta(HoodieDeltaStreamerMetrics metrics) {
public void syncHive() {
HiveSyncConfig hiveSyncConfig = DataSourceUtils.buildHiveSyncConfig(props,
cfg.targetBasePath, cfg.baseFileFormat);
- LOG.info("Syncing target hoodie table with hive table(" +
hiveSyncConfig.tableName + "). Hive metastore URL :"
- + hiveSyncConfig.jdbcUrl + ", basePath :" + cfg.targetBasePath);
HiveConf hiveConf = new HiveConf(conf, HiveConf.class);
+ if
(!DataSourceWriteOptions.METASTORE_URIS().defaultValue().equals(hiveSyncConfig.metastoreUris))
{
Review comment:
Why do we need to check this? Why not simply set whatever user has
passed irrespective of the default value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
