nsivabalan commented on pull request #3824:
URL: https://github.com/apache/hudi/pull/3824#issuecomment-947894275


   Also, checked 
[HoodieHeartBeatClient](https://github.com/apache/hudi/blob/master/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/heartbeat/HoodieHeartbeatClient.java)
 to check if we have any interplay there. 
   
   Looks like this is what we are doing and looks like we may not need any 
changes. just wanted to bring to others notice. 
   
   Every commit will create a file under heartbeat folder. file name is same as 
instant time. 
   And at regular intervals will keep overriding it. and we rely on 
lastModification time of the file to check for expiration at regular cadence. 
   @davehagman :  can you confirm my understanding. old commit times will still 
be interpreted as is and we don't upgrade them every to new format right. Just 
that the newer ones we generated are in new format. 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to