nsivabalan commented on a change in pull request #3762:
URL: https://github.com/apache/hudi/pull/3762#discussion_r733024013
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java
##########
@@ -132,18 +149,31 @@ protected AbstractHoodieLogRecordScanner(FileSystem fs,
String basePath, List<St
}
this.totalLogFiles.addAndGet(logFilePaths.size());
this.logFilePaths = logFilePaths;
- this.readBlocksLazily = readBlocksLazily;
this.reverseReader = reverseReader;
+ this.readBlocksLazily = readBlocksLazily;
this.fs = fs;
this.bufferSize = bufferSize;
this.instantRange = instantRange;
this.withOperationField = withOperationField;
+ this.enableInlineReading = enableInlineReading;
+ this.enableFullScan = enableFullScan;
+ if (!enableFullScan) {
+ ValidationUtils.checkArgument(enableInlineReading, "Inline should be
enabled if full scan is not enabled");
+ }
}
- /**
- * Scan Log files.
- */
public void scan() {
+ scan(Collections.emptyList());
Review comment:
yeah. I thought of adding a boolean flag. But had a dilemma, that we
could rely on the list size to determine whether its full scan or pointed look
ups. Only other option I could think of is to introduce another boolean flag to
denote whether we read all records or only interested records. will see what
can be done here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
