yanghua commented on a change in pull request #3842:
URL: https://github.com/apache/hudi/pull/3842#discussion_r734173285
##########
File path: hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSource.java
##########
@@ -180,15 +180,17 @@ public boolean isBounded() {
conf, FilePathUtils.toFlinkPath(path),
maxCompactionMemoryInBytes, getRequiredPartitionPaths());
InputFormat<RowData, ?> inputFormat = getInputFormat(true);
OneInputStreamOperatorFactory<MergeOnReadInputSplit, RowData>
factory = StreamReadOperator.factory((MergeOnReadInputFormat) inputFormat);
- SingleOutputStreamOperator<RowData> source =
execEnv.addSource(monitoringFunction, "split_monitor")
+ SingleOutputStreamOperator<RowData> source =
execEnv.addSource(monitoringFunction,
+ "split_monitor(table=[" +
conf.getString(FlinkOptions.TABLE_NAME) + "], fields=" +
schema.getColumnNames() + ")")
Review comment:
@mincwang Would you mind extract this part:
`table=[" + conf.getString(FlinkOptions.TABLE_NAME) + "], fields=" +
schema.getColumnNames() + ")"`
into a variable to let it could be shared both in if/else block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
