[GitHub] [hudi] nsivabalan commented on a change in pull request #3802: [HUDI-1500] Support replace commit in DeltaSync with commit metadata preserved

[GitBox]

nsivabalan commented on a change in pull request #3802:
URL: https://github.com/apache/hudi/pull/3802#discussion_r735621999



##########
File path: 
hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieDeltaStreamer.java
##########
@@ -1137,8 +1144,9 @@ public void testHoodieAsyncClusteringJob() throws 
Exception {
     });
   }
 
-  @Test
-  public void testAsyncClusteringService() throws Exception {
+  @ParameterizedTest
+  @ValueSource(strings = {"true", "false"})
+  public void testAsyncClusteringService(String preserveCommitMetadata) throws 
Exception {

Review comment:
       @codope : do we still need to test with async as well, since you have 
added one for inline already ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org