yihua commented on a change in pull request #3778:
URL: https://github.com/apache/hudi/pull/3778#discussion_r736164950
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndex.java
##########
@@ -53,17 +53,19 @@ protected HoodieIndex(HoodieWriteConfig config) {
* present).
*/
@PublicAPIMethod(maturity = ApiMaturityLevel.STABLE)
- public abstract I tagLocation(I records, HoodieEngineContext context,
- HoodieTable<T, I, K, O> hoodieTable) throws
HoodieIndexException;
+ public abstract HoodieData<HoodieRecord<T>> tagLocation(
Review comment:
Right. As discussed, I keep two sets of APIs now, the old ones with
specific types (`I` and `O`) which are the same as before and going to be
deprecated in the future, and the new ones using HoodieData abstraction.
SparkHoodieIndex, FlinkHoodieIndex, and JavaHoodieIndex, which are extended by
users, have the new APIs wrapping around the old APIs implemented by the users,
which are compatible after the refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
