YannByron commented on a change in pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#discussion_r736724131
##########
File path:
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -64,7 +67,7 @@ object HoodieSparkSqlWriter {
def write(sqlContext: SQLContext,
mode: SaveMode,
- parameters: Map[String, String],
+ optParams: Map[String, String],
Review comment:
It's needed. The `parameters` variable includes all default hoodie's
parameters, and will be used as following codes. The `optParams` variable just
used to validate whether there are conflicts between these and TableConfig.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
