davehagman commented on a change in pull request #3824:
URL: https://github.com/apache/hudi/pull/3824#discussion_r736793931
##########
File path: hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java
##########
@@ -423,8 +423,8 @@ public static String medianInstantTime(String highVal,
String lowVal) {
*/
public static long instantTimeDiffSeconds(String newInstantTime, String
oldInstantTime) {
try {
- long newTimestamp =
HoodieActiveTimeline.COMMIT_FORMATTER.parse(newInstantTime).getTime();
- long oldTimestamp =
HoodieActiveTimeline.COMMIT_FORMATTER.parse(oldInstantTime).getTime();
+ long newTimestamp =
HoodieActiveTimeline.parseDateFromInstantTime(newInstantTime).getTime();
Review comment:
The `getTime()` method always returns millis and it tested
[here](https://github.com/apache/hudi/blob/master/hudi-flink/src/test/java/org/apache/hudi/utils/TestStreamerUtil.java#L96).
Everything appears to be working as expected. What issue(s) do you currently
see?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
