guanziyue commented on a change in pull request #3912: URL: https://github.com/apache/hudi/pull/3912#discussion_r741670205
########## File path: hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java ########## @@ -148,10 +148,11 @@ public AppendResult appendBlocks(List<HoodieLogBlock> blocks) throws IOException HoodieLogFormat.LogFormatVersion currentLogFormatVersion = new HoodieLogFormatVersion(HoodieLogFormat.CURRENT_VERSION); - FSDataOutputStream outputStream = getOutputStream(); - long startPos = outputStream.getPos(); + FSDataOutputStream originalOutputStream = getOutputStream(); Review comment: Ummm. Yes we could have a test to write a huge log block to have a check. But it may affect UT performance a lot. Not sure if an UT relevant to such a reworking of existing logic is necessary. Anyway, I'm glad to add a UT if it is compulsory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org