vinothchandar commented on a change in pull request #3880:
URL: https://github.com/apache/hudi/pull/3880#discussion_r743976266
##########
File path: packaging/hudi-hive-sync-bundle/pom.xml
##########
@@ -69,12 +69,18 @@
<include>org.apache.hudi:hudi-sync-common</include>
<include>org.apache.hudi:hudi-hive-sync</include>
+ <include>org.apache.hbase:hbase-client</include>
+ <include>org.apache.hbase:hbase-common</include>
Review comment:
this is an include right? in the bundle? why `test` scope? sorry not
following?
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java
##########
@@ -45,7 +45,7 @@
.sinceVersion("0.7.0")
.withDocumentation("Enable the internal metadata table which serves
table metadata like level file listings");
- public static final boolean DEFAULT_METADATA_ENABLE_FOR_READERS = false;
+ public static final boolean DEFAULT_METADATA_ENABLE_FOR_READERS = true;
Review comment:
does this generally handle the scenario where the metadata table is not
present? or being blown away.
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java
##########
@@ -45,7 +45,7 @@
.sinceVersion("0.7.0")
.withDocumentation("Enable the internal metadata table which serves
table metadata like level file listings");
- public static final boolean DEFAULT_METADATA_ENABLE_FOR_READERS = false;
+ public static final boolean DEFAULT_METADATA_ENABLE_FOR_READERS = true;
Review comment:
Also what engines work off this? Spark, Hive, Presto and also Flink?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
