minihippo commented on a change in pull request #3173:
URL: https://github.com/apache/hudi/pull/3173#discussion_r744630064



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/model/HoodieKey.java
##########
@@ -31,13 +35,16 @@
 
   private String recordKey;
   private String partitionPath;
+  private List<Object> indexKey;
 
-  public HoodieKey() {
+  public HoodieKey(String recordKey, String partitionPath) {
+    this(recordKey, partitionPath, Collections.emptyList());
   }
 
-  public HoodieKey(String recordKey, String partitionPath) {
+  public HoodieKey(String recordKey, String partitionPath, List<Object> 
indexKey) {

Review comment:
       Index key is used to tag location and cluster the insert/upsert data. To 
avoid repeated serialization and deserialization, can we store the index key 
and save it in `HoodieRecord`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to