yihua commented on a change in pull request #4172:
URL: https://github.com/apache/hudi/pull/4172#discussion_r763256810
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieDefaultTimeline.java
##########
@@ -136,6 +136,14 @@ public HoodieTimeline filterPendingCompactionTimeline() {
instants.stream().filter(s ->
s.getAction().equals(HoodieTimeline.COMPACTION_ACTION) && !s.isCompleted()),
details);
}
+ @Override
+ public HoodieTimeline filterPendingCompactionAndReplaceTimeline() {
Review comment:
Not required in this PR. In general, should we have something like
`filterPendingTableServicesTimeline()` so that any new async table service
should not cause the same problem of staining the timeline again? or maybe
filter `!s.isCompleted()` only?
As a side note, the `COMPACTION_ACTION` only appears if it is not complete.
Once the compaction is complete, it shows as a completed `commit` instead of
completed `compaction` in the timeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
