garyli1019 commented on a change in pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#discussion_r765612550
##########
File path:
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieMergeOnReadRDD.scala
##########
@@ -84,6 +86,10 @@ class HoodieMergeOnReadRDD(@transient sc: SparkContext,
s"spark partition Index: ${mergeOnReadPartition.index}" +
s"merge type: ${mergeOnReadPartition.split.mergeType}")
}
+ if (iter.isInstanceOf[Closeable]) {
+ Option(TaskContext.get()).foreach(_.addTaskCompletionListener[Unit](_ =>
iter.asInstanceOf[Closeable].close()))
Review comment:
would you add some comments about this? not quite sure how this work
##########
File path:
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieMergeOnReadRDD.scala
##########
@@ -18,6 +18,8 @@
package org.apache.hudi
+import java.io.Closeable
Review comment:
move to above scala import?
##########
File path:
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieMergeOnReadRDD.scala
##########
@@ -146,12 +153,16 @@ class HoodieMergeOnReadRDD(@transient sc: SparkContext,
override def next(): InternalRow = {
recordToLoad
}
+
+ override def close(): Unit = {
+ if (logScanner != null) logScanner.close()
Review comment:
how about add `logScanner = null` after
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
